r84539 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84538‎ | r84539 | r84540 >
Date:17:31, 22 March 2011
Author:purodha
Status:deferred
Tags:
Comment:
Followup for r84446 and r84447 making some check for variables optional.
Modified paths:
  • /trunk/extensions/Translate/check-blacklist.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/check-blacklist.php
@@ -211,10 +211,17 @@
212212 'group' => 'ext-flaggedrevs-reviewedpages',
213213 'check' => 'variable',
214214 'message' => array(
215 - 'reviewedpages-list', // Parameter only used when required for plural
 215+ 'reviewedpages-list', // Parameter $1 only used when required for plural
216216 )
217217 ),
218218 array(
 219+ 'group' => 'ext-flaggedrevs-unreviewedpages',
 220+ 'check' => 'variable',
 221+ 'message' => array(
 222+ 'unreviewedpages-list', // Parameter $1 only used when required for plural
 223+ )
 224+),
 225+array(
219226 'group' => 'ext-flaggedrevs-reviewedversions',
220227 'check' => 'variable',
221228 'message' => array(
@@ -229,6 +236,34 @@
230237 )
231238 ),
232239 array(
 240+ 'group' => 'ext-flaggedrevs-pendingchanges',
 241+ 'check' => 'variable',
 242+ 'message' => array(
 243+ 'pendingchanges-list', // Parameter $1 only used when required for plural
 244+ )
 245+),
 246+array(
 247+ 'group' => 'ext-flaggedrevs-problemchanges',
 248+ 'check' => 'variable',
 249+ 'message' => array(
 250+ 'problemchanges-list', // Parameter $1 only used when required for plural
 251+ )
 252+),
 253+array(
 254+ 'group' => 'ext-flaggedrevs-qualityoversight',
 255+ 'check' => 'variable',
 256+ 'message' => array(
 257+ 'qualityoversight-list', // Parameter $1 only used when required for plural
 258+ )
 259+),
 260+array(
 261+ 'group' => 'ext-flaggedrevs-configuredpages',
 262+ 'check' => 'variable',
 263+ 'message' => array(
 264+ 'configuredpages-list', // Parameter $1 only used when required for plural
 265+ )
 266+),
 267+array(
233268 'group' => 'ext-liquidthreads',
234269 'check' => 'variable',
235270 'message' => array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84446* Pass pager->getNumRows() into explanatory message...aaron14:32, 21 March 2011
r84447* Follow-up r84446: use formatNum()...aaron14:49, 21 March 2011

Status & tagging log