r84416 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84415‎ | r84416 | r84417 >
Date:20:50, 20 March 2011
Author:aaron
Status:ok
Tags:
Comment:
More comments on hash inputs
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/RepoGroup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -185,7 +185,7 @@
186186
187187 /**
188188 * Create a new File object from the local repository
189 - * @param $sha1 Mixed: SHA-1 key
 189+ * @param $sha1 Mixed: base 36 SHA-1 hash
190190 * @param $time Mixed: time at which the image was uploaded.
191191 * If this is specified, the returned object will be an
192192 * of the repository's old file class instead of a current
@@ -211,7 +211,7 @@
212212 * Returns false if the file does not exist. Repositories not supporting
213213 * version control should return false if the time is specified.
214214 *
215 - * @param $sha1 String
 215+ * @param $sha1 String base 36 SHA-1 hash
216216 * @param $options Option array, same as findFile().
217217 */
218218 function findFileFromKey( $sha1, $options = array() ) {
Index: trunk/phase3/includes/filerepo/RepoGroup.php
@@ -215,7 +215,7 @@
216216 * Find an instance of the file with this key, created at the specified time
217217 * Returns false if the file does not exist.
218218 *
219 - * @param $hash String SHA-1
 219+ * @param $hash String base 36 SHA-1 hash
220220 * @param $options Option array, same as findFile()
221221 * @return File object or false if it is not found
222222 */
@@ -237,7 +237,7 @@
238238 /**
239239 * Find all instances of files with this key
240240 *
241 - * @param $hash String SHA-1
 241+ * @param $hash String base 36 SHA-1 hash
242242 * @return Array of File objects
243243 */
244244 function findBySha1( $hash ) {

Sign-offs

UserFlagDate
Tim Starlinginspected05:04, 2 September 2011

Status & tagging log