r84410 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84409‎ | r84410 | r84411 >
Date:18:47, 20 March 2011
Author:maxsem
Status:ok
Tags:
Comment:
Installer: require_once extensions, simple require can cause problems with extensions implicitly depending on other extensions (e.g. Maps already requires Validator, if user checks Validator, xe gets a fatal).
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
——@@ -1200,7 +1200,7 @@
12011201 require( "$IP/includes/DefaultSettings.php" );
12021202
12031203 foreach( $exts as $e ) {
1204 - require( "$path/$e/$e.php" );
 1204+ require_once( "$path/$e/$e.php" );
12051205 }
12061206
12071207 $hooksWeWant = isset( $wgHooks['LoadExtensionSchemaUpdates'] ) ?

Status & tagging log