r84407 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84406‎ | r84407 | r84408 >
Date:17:48, 20 March 2011
Author:aaron
Status:ok
Tags:
Comment:
Minor HTML cleanups
Modified paths:
  • /trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
@@ -727,7 +727,8 @@
728728 }
729729
730730 # Add main checkboxes/selects
731 - $form .= Xml::openElement( 'span', array( 'id' => 'mw-fr-ratingselects' ) );
 731+ $form .= Xml::openElement( 'span',
 732+ array( 'id' => 'mw-fr-ratingselects', 'class' => 'fr-rating-options' ) );
732733 $form .= self::ratingInputs( $user, $flags, (bool)$disabled, (bool)$frev );
733734 $form .= Xml::closeElement( 'span' );
734735 # Add review notes input
@@ -870,7 +871,7 @@
871872 if ( $size > 6 ) {
872873 $attribs = array( 'name' => "wp$quality", 'id' => "wp$quality",
873874 'onchange' => "FlaggedRevsReview.updateRatingForm()" );
874 - $item .= Xml::openElement( 'select', $attribs );
 875+ $item .= Xml::openElement( 'select', $attribs ) . "\n";
875876 foreach ( $levels as $i => $name ) {
876877 $optionClass = array( 'class' => "fr-rating-option-$i" );
877878 $item .= Xml::option( FlaggedRevs::getTagMsg( $name ), $i,
@@ -897,11 +898,7 @@
898899 $items[] = $item;
899900 }
900901 }
901 - # Wrap visible controls in a span
902 - $form = Xml::openElement( 'span', array( 'class' => 'fr-rating-options' ) ) . "\n";
903 - $form .= implode( '   ', $items );
904 - $form .= Xml::closeElement( 'span' ) . "\n";
905 - return $form;
 902+ return implode( '   ', $items );
906903 }
907904
908905 private static function ratingFormTags( $user, $selected ) {

Status & tagging log