r84375 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84374‎ | r84375 | r84376 >
Date:12:49, 20 March 2011
Author:ialex
Status:deferred
Tags:
Comment:
Naming a parameter after a global variable is really a bad idea
Modified paths:
  • /trunk/extensions/IncludeWP/IncludeWP.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/IncludeWP/IncludeWP.class.php
@@ -30,10 +30,10 @@
3131 * No LSB in pre-5.3 PHP *sigh*.
3232 * This is to be refactored as soon as php >=5.3 becomes acceptable.
3333 */
34 - public static function staticInit( Parser &$wgParser ) {
 34+ public static function staticInit( Parser &$parser ) {
3535 $className = __CLASS__;
3636 $instance = new $className();
37 - return $instance->init( $wgParser );
 37+ return $instance->init( $parser );
3838 }
3939
4040 /**

Status & tagging log