r84370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84369‎ | r84370 | r84371 >
Date:02:05, 20 March 2011
Author:aaron
Status:ok
Tags:
Comment:
Removed linkbatch queries that have no benefit (in these cases)
Modified paths:
  • /trunk/extensions/FlaggedRevs/specialpages/PendingChanges_body.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/PendingChanges_body.php
@@ -411,14 +411,6 @@
412412 }
413413
414414 function getStartBody() {
415 - wfProfileIn( __METHOD__ );
416 - # Do a link batch query
417 - $lb = new LinkBatch();
418 - foreach ( $this->mResult as $row ) {
419 - $lb->add( $row->page_namespace, $row->page_title );
420 - }
421 - $lb->execute();
422 - wfProfileOut( __METHOD__ );
423415 return '<ul>';
424416 }
425417
Index: trunk/extensions/FlaggedRevs/specialpages/UnreviewedPages_body.php
@@ -132,8 +132,7 @@
133133 }
134134 $css = self::getLineClass( $hours, $uw );
135135 $css = $css ? " class='$css'" : "";
136 - $pageId = isset( $row->page_id ) ?
137 - $row->page_id : $row->qc_value;
 136+ $pageId = isset( $row->page_id ) ? $row->page_id : $row->qc_value;
138137 $key = wfMemcKey( 'unreviewedPages', 'underReview', $pageId );
139138 $val = $wgMemc->get( $key );
140139 # Show if a user is looking at this page
@@ -361,14 +360,6 @@
362361 }
363362
364363 function getStartBody() {
365 - wfProfileIn( __METHOD__ );
366 - # Do a link batch query
367 - $lb = new LinkBatch();
368 - foreach ( $this->mResult as $row ) {
369 - $lb->add( $row->page_namespace, $row->page_title );
370 - }
371 - $lb->execute();
372 - wfProfileOut( __METHOD__ );
373364 return '<ul>';
374365 }
375366

Status & tagging log