r84364 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84363‎ | r84364 | r84365 >
Date:00:32, 20 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r84361, numerical keys ftw
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -258,11 +258,9 @@
259259 }
260260
261261 $builtGroups = array();
262 - $i = 0;
263 - foreach( array_merge( $groups, Autopromote::getAutopromoteGroups( $user ) ) as $g ) {
 262+ foreach( array_merge( $groups, Autopromote::getAutopromoteGroups( $user ) ) as $i => $group ) {
264263 $builtGroups[$i] = array( 'implicit' => '' );
265 - ApiResult::setContent( $builtGroups[$i], $g );
266 - $i++;
 264+ ApiResult::setContent( $builtGroups[$i], $group );
267265 }
268266 return $builtGroups;
269267 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84361* (bug 27469) label implicit groups in list=allusers&auprop=groups/list=users...reedy00:19, 20 March 2011

Status & tagging log