r84340 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84339‎ | r84340 | r84341 >
Date:17:59, 19 March 2011
Author:tbleher
Status:ok
Tags:
Comment:
Fix indentation
Modified paths:
  • /trunk/extensions/DSMW/logootComponent/LogootId.php (modified) (history)
  • /trunk/extensions/DSMW/logootComponent/LogootPosition.php (modified) (history)
  • /trunk/extensions/ImageTagging/ImageTagging.php (modified) (history)
  • /trunk/extensions/MostRevisors/MostRevisors_body.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/ThreadProtectionFormView.php (modified) (history)
  • /trunk/extensions/RdfRedland/Special/QueryPage.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/specials/SMWNotifyMe/SMWNotifyMe.php (modified) (history)
  • /trunk/extensions/SemanticProjectManagement/includes/SPM_GanttChart.php (modified) (history)
  • /trunk/extensions/SemanticProjectManagement/includes/SPM_ProjectManagementClass.php (modified) (history)
  • /trunk/extensions/SemanticProjectManagement/includes/SPM_WBS.php (modified) (history)
  • /trunk/extensions/UsageStatistics/UsageStatistics_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DSMW/logootComponent/LogootId.php
@@ -50,13 +50,13 @@
5151 $val2 = new Math_BigInteger( $logid->mInt );
5252
5353 if ( ( $val1->compare( $val2 ) ) < 0 )
54 - return -1;
 54+ return -1;
5555 else if ( ( $val1->compare( $val2 ) ) > 0 )
56 - return 1;
 56+ return 1;
5757 else if ( strcmp( $this->mSessionId, $logid->mSessionId ) < 0 )
58 - return -1;
 58+ return -1;
5959 else if ( strcmp( $this->mSessionId, $logid->mSessionId ) > 0 )
60 - return 1;
 60+ return 1;
6161 return 0;
6262 }
6363
Index: trunk/extensions/DSMW/logootComponent/LogootPosition.php
@@ -24,7 +24,7 @@
2525 while ( $i < $max ) {
2626
2727 if ( $thisPos[$i]->compareTo( $position->mPosition[$i] ) != 0 )
28 - break;
 28+ break;
2929 $i++;
3030 }
3131 if ( $i >= $this->size() && $i >= $position->size() )return 0;
Index: trunk/extensions/SemanticProjectManagement/includes/SPM_WBS.php
@@ -169,7 +169,7 @@
170170
171171 $hasChildren = $allTempChildren;
172172 if (count($hasChildren)>0)
173 - $hasChild = true;
 173+ $hasChild = true;
174174 }
175175
176176 $task->addWBS(1,0);
@@ -206,4 +206,4 @@
207207
208208
209209 }
210 -}
\ No newline at end of file
 210+}
Index: trunk/extensions/SemanticProjectManagement/includes/SPM_GanttChart.php
@@ -181,7 +181,7 @@
182182
183183 $hasChildren = $allTempChildren;
184184 if (count($hasChildren)>0)
185 - $hasChild = true;
 185+ $hasChild = true;
186186 }
187187
188188 $task->addWBS(1,0);
@@ -190,4 +190,4 @@
191191
192192
193193 }
194 -}
\ No newline at end of file
 194+}
Index: trunk/extensions/SemanticProjectManagement/includes/SPM_ProjectManagementClass.php
@@ -299,10 +299,10 @@
300300 static function cmpDate($task1,$task2){
301301 $date1 = $task1->getPlannedStartDate();
302302 if ($date1!=null)
303 - $res1 = strtotime($date1->getXMLSchemaDate());
 303+ $res1 = strtotime($date1->getXMLSchemaDate());
304304 $date2 = $task2->getPlannedStartDate();
305305 if ($date2!=null)
306 - $res2 = strtotime($date2->getXMLSchemaDate());
 306+ $res2 = strtotime($date2->getXMLSchemaDate());
307307 return ($res1<$res2);
308308
309309 }
@@ -826,7 +826,7 @@
827827 $time1 = explode("T",$date);
828828 $time2 = explode("-",$time1[0]);
829829 if (count($time1)>1){
830 - $time3 = explode(":",$time1[1]);
 830+ $time3 = explode(":",$time1[1]);
831831 } else {
832832 $time3 = array(0,0,0);
833833 }
@@ -1746,7 +1746,7 @@
17471747 $res .= "<Type>2</Type>\r\n";
17481748 $res .= "<IsNull>0</IsNull>\r\n";
17491749 if($this->m_timestamp!=null)
1750 - $res .= "<CreateDate>" . date("Y-m-d", $this->m_timestamp) . "T" . date("H:i:s", $this->m_timestamp) . "</CreateDate>\r\n";
 1750+ $res .= "<CreateDate>" . date("Y-m-d", $this->m_timestamp) . "T" . date("H:i:s", $this->m_timestamp) . "</CreateDate>\r\n";
17511751 $res .= "<WBS>" . $this->WBStoSTring($this->m_WBS) . "</WBS>\r\n";
17521752 $res .= "<OutlineNumber>" . $this->WBStoSTring($this->m_WBS) . "</OutlineNumber>\r\n";
17531753 $res .= "<OutlineLevel>" . $this->m_outlineLevel . "</OutlineLevel>\r\n";
@@ -1757,15 +1757,15 @@
17581758 $res .= "<ConstraintDate>" . $this->parsedate($this->m_plannedStart) . "</ConstraintDate>\r\n";
17591759 }
17601760 if ($this->m_plannedFinish!=null)
1761 - $res .= "<Finish>" . $this->parsedate($this->m_plannedFinish) . "</Finish>\r\n";
 1761+ $res .= "<Finish>" . $this->parsedate($this->m_plannedFinish) . "</Finish>\r\n";
17621762 if ($this->m_earlyStart!=null)
1763 - $res .= "<EarlyStart>" . $this->parsedate($this->m_earlyStart) . "</EarlyStart>\r\n";
 1763+ $res .= "<EarlyStart>" . $this->parsedate($this->m_earlyStart) . "</EarlyStart>\r\n";
17641764 if ($this->m_earlyFinish!=null)
1765 - $res .= "<EarlyFinish>" . $this->parsedate($this->m_earlyFinish) . "</EarlyFinish>\r\n";
 1765+ $res .= "<EarlyFinish>" . $this->parsedate($this->m_earlyFinish) . "</EarlyFinish>\r\n";
17661766 if ($this->m_lateStart!=null)
1767 - $res .= "<LateStart>" . $this->parsedate($this->m_lateStart) . "</LateStart>\r\n";
 1767+ $res .= "<LateStart>" . $this->parsedate($this->m_lateStart) . "</LateStart>\r\n";
17681768 if ($this->m_lateFinish!=null)
1769 - $res .= "<LateFinish>" . $this->parsedate($this->m_lateFinish) . "</LateFinish>\r\n";
 1769+ $res .= "<LateFinish>" . $this->parsedate($this->m_lateFinish) . "</LateFinish>\r\n";
17701770 $res .= "<Hyperlink>".$this->replaceLabelChars($this->getLabel())."</Hyperlink>\r\n";
17711771 $res .= "<HyperlinkAddress>". $this->m_hyperlink ."</HyperlinkAddress>\r\n";
17721772 foreach ($this->m_predecessors as $pred){
@@ -1824,4 +1824,4 @@
18251825 return $res;
18261826 }
18271827
1828 -}
\ No newline at end of file
 1828+}
Index: trunk/extensions/SemanticNotifyMe/specials/SMWNotifyMe/SMWNotifyMe.php
@@ -247,7 +247,7 @@
248248 <td><a href="#" onclick="notifyhelper.showall(true)">' . wfMsg( 'smw_nm_special_all' ) . '</a>/<a href="#" onclick="notifyhelper.showall(false)">' . wfMsg( 'smw_nm_special_none' ) . '</a>&#160; <button class="btn" onclick="notifyhelper.updateShowAll()" onmouseover="this.className=\'btn btnhov\'; Tip(\'' . wfMsg( 'smw_nm_special_tt_showupdate' ) . '\')" onmouseout="this.className=\'btn\'">' . wfMsg( 'smw_nm_special_update' ) . '</button></td>
249249 <td><a href="#" onclick="notifyhelper.enableall(true)">' . wfMsg( 'smw_nm_special_all' ) . '</a>/<a href="#" onclick="notifyhelper.enableall(false)">' . wfMsg( 'smw_nm_special_none' ) . '</a>&#160; <button class="btn" onclick="notifyhelper.updateStates()" onmouseover="this.className=\'btn btnhov\'; Tip(\'' . wfMsg( 'smw_nm_special_tt_enableupdate' ) . '\')" onmouseout="this.className=\'btn\'">' . wfMsg( 'smw_nm_special_update' ) . '</button></td>';
250250 if ( $isSysop )
251 - $html .= '<td><button class="btn" onclick="notifyhelper.updateDelegate()" onmouseover="this.className=\'btn btnhov\'; Tip(\'' . wfMsg( 'smw_nm_special_tt_delegateupdate' ) . '\')" onmouseout="this.className=\'btn\'">' . wfMsg( 'smw_nm_special_update' ) . '</button></td>';
 251+ $html .= '<td><button class="btn" onclick="notifyhelper.updateDelegate()" onmouseover="this.className=\'btn btnhov\'; Tip(\'' . wfMsg( 'smw_nm_special_tt_delegateupdate' ) . '\')" onmouseout="this.className=\'btn\'">' . wfMsg( 'smw_nm_special_update' ) . '</button></td>';
252252 $html .= '</tr></table>';
253253 return $html;
254254 }
Index: trunk/extensions/UsageStatistics/UsageStatistics_body.php
@@ -443,9 +443,9 @@
444444 for ( $i = 1; $i <= 7; $i++ )
445445 {
446446 if ( method_exists( $wgContLang, 'getWeekdayAbbreviation' ) )
447 - $daynames .= "'" . $wgContLang->getWeekdayAbbreviation( $i ) . "',";
 447+ $daynames .= "'" . $wgContLang->getWeekdayAbbreviation( $i ) . "',";
448448 else
449 - $daynames .= "'" . $wgContLang->getWeekdayName( $i ) . "',";
 449+ $daynames .= "'" . $wgContLang->getWeekdayName( $i ) . "',";
450450 }
451451 $daynames = substr( $daynames, 0, - 1 );
452452
Index: trunk/extensions/MostRevisors/MostRevisors_body.php
@@ -70,7 +70,7 @@
7171 if ( $count > 0 ) {
7272 # Make list
7373 if ( !$this->mIncluding )
74 - $wgOut->addWikiMsg( 'mostrevisors-showing', $wgLang->formatNum( $count ) );
 74+ $wgOut->addWikiMsg( 'mostrevisors-showing', $wgLang->formatNum( $count ) );
7575 $wgOut->addHTML( "<ol>" );
7676 foreach ( $res as $row ) {
7777 $wgOut->addHTML( $this->makeListItem( $row ) );
Index: trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/ThreadProtectionFormView.php
@@ -7,9 +7,9 @@
88 ThreadPermalinkView::customizeThreadTabs( $skintemplate, $content_actions, $this );
99
1010 if ( array_key_exists( 'protect', $content_actions ) )
11 - $content_actions['protect']['class'] = 'selected';
 11+ $content_actions['protect']['class'] = 'selected';
1212 else if ( array_key_exists( 'unprotect', $content_actions ) )
13 - $content_actions['unprotect']['class'] = 'selected';
 13+ $content_actions['unprotect']['class'] = 'selected';
1414 }
1515
1616 function customizeNavigation( $skintemplate, &$links ) {
Index: trunk/extensions/RdfRedland/Special/QueryPage.php
@@ -89,17 +89,17 @@
9090 if ( $num > 0 ) {
9191 $s = array();
9292 if ( ! $this->listoutput )
93 - $s[] = "<ol start='" . ( $offset + 1 ) . "' class='special'>";
 93+ $s[] = "<ol start='" . ( $offset + 1 ) . "' class='special'>";
9494
9595 # here's where we do the offset and limit
9696 for ( $i = $offset; $i < $num && $i < $offset + $limit; $i++ ) {
9797 $format = $this->formatResult( $sk, $res[$i] );
9898 if ( $format )
99 - $s[] = $this->listoutput ? $format : "<li>{$format}</li>\n";
 99+ $s[] = $this->listoutput ? $format : "<li>{$format}</li>\n";
100100 }
101101
102102 if ( ! $this->listoutput )
103 - $s[] = '</ol>';
 103+ $s[] = '</ol>';
104104 $str = $this->listoutput ? $wgContLang->listToText( $s ) : implode( '', $s );
105105 $wgOut->addHTML( $str );
106106 }
Index: trunk/extensions/ImageTagging/ImageTagging.php
@@ -201,7 +201,7 @@
202202
203203 $numResults = ( $titleMatches ? $titleMatches->numRows() : 0 );
204204 if ( $numResults > 0 )
205 - $wgOut->addHTML(wfTagSearchShowMatches($titleMatches));
 205+ $wgOut->addHTML(wfTagSearchShowMatches($titleMatches));
206206
207207 #echo "numResults: " . $numResults . ", query: " . $query;
208208
@@ -335,7 +335,7 @@
336336 $wgOut->addHTML("<!-- this many image tags: " . count($res) . " from img " . $img->name . " -->");
337337 while ($o = $db->fetchObject($res)) {
338338 if ( strlen($html) > 0 )
339 - $html .= ', ';
 339+ $html .= ', ';
340340
341341 $wgOut->addHTML("<!-- tag rect: " . $o->tag_rect . ", tag title: " . $o->article_tag . ", unique_id: " . $o->unique_id . "-->");
342342
@@ -358,7 +358,7 @@
359359 $db->freeResult($res);
360360
361361 if ( $html )
362 - $html = wfMsg('imagetagging-inthisimage', $html);
 362+ $html = wfMsg('imagetagging-inthisimage', $html);
363363
364364 wfProfileOut( __METHOD__ );
365365 return $html;

Status & tagging log