r84332 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84331‎ | r84332 | r84333 >
Date:16:41, 19 March 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Remove some insanely ancient (~r4797) unused globals and variables, and make private variables actually private (no external calls to worry about)
Modified paths:
  • /trunk/phase3/includes/Block.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -18,12 +18,8 @@
1919 /* public*/ var $mAddress, $mUser, $mBy, $mReason, $mTimestamp, $mAuto, $mId, $mExpiry,
2020 $mRangeStart, $mRangeEnd, $mAnonOnly, $mEnableAutoblock, $mHideName,
2121 $mBlockEmail, $mByName, $mAngryAutoblock, $mAllowUsertalk;
22 - /* private */ var $mNetworkBits, $mIntegerAddr, $mForUpdate, $mFromMaster;
 22+ private $mForUpdate, $mFromMaster;
2323
24 - const EB_KEEP_EXPIRED = 1;
25 - const EB_FOR_UPDATE = 2;
26 - const EB_RANGE_ONLY = 4;
27 -
2824 const TYPE_USER = 1;
2925 const TYPE_IP = 2;
3026 const TYPE_RANGE = 3;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r4797Added FOR UPDATE mode to Block.php, to fix memcached concurrency problem in B...timstarling07:23, 15 August 2004

Status & tagging log