r84289 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84288‎ | r84289 | r84290 >
Date:23:54, 18 March 2011
Author:reedy
Status:deferred
Tags:
Comment:
Remove unused globals, add missing global
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaSudoer.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaSudoer.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaSudoer.php
@@ -37,7 +37,7 @@
3838 * @return bool
3939 */
4040 function createSudoer() {
41 - global $wgRequest, $wgOut;
 41+ global $wgOut;
4242
4343 $this->setHeaders();
4444 $wgOut->setPagetitle( wfMsg( 'openstackmanager-createsudoer' ) );
Index: trunk/extensions/OpenStackManager/OpenStackNovaSudoer.php
@@ -131,7 +131,6 @@
132132 function modifySudoer( $users, $hosts, $commands, $options ) {
133133 global $wgAuth;
134134 global $wgOpenStackManagerLDAPUser, $wgOpenStackManagerLDAPUserPassword;
135 - global $wgOpenStackManagerLDAPSudoerBaseDN;
136135 global $wgOpenStackManagerLDAPDomain;
137136
138137 $wgAuth->connect( $wgOpenStackManagerLDAPDomain );
@@ -172,7 +171,7 @@
173172 static function getAllSudoers() {
174173 global $wgAuth;
175174 global $wgOpenStackManagerLDAPUser, $wgOpenStackManagerLDAPUserPassword;
176 - global $wgOpenStackManagerLDAPSudoerBaseDN;
 175+ global $wgOpenStackManagerLDAPSudoerBaseDN, $wgOpenStackManagerLDAPDomain;
177176
178177 $wgAuth->connect( $wgOpenStackManagerLDAPDomain );
179178 $wgAuth->bindAs( $wgOpenStackManagerLDAPUser, $wgOpenStackManagerLDAPUserPassword );

Status & tagging log