r84275 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84274‎ | r84275 | r84276 >
Date:22:16, 18 March 2011
Author:krinkle
Status:ok
Tags:
Comment:
per r83658 CR: mw.log.prefix is for identifying windows, not context. Using string concat instead
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.makeCollapsible.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.makeCollapsible.js
@@ -19,7 +19,7 @@
2020 $.fn.makeCollapsible = function() {
2121
2222 return this.each(function() {
23 - mw.config.set( 'mw.log.prefix', 'jquery.makeCollapsible' );
 23+ var _fn = 'jquery.makeCollapsible> ';
2424
2525 // Define reused variables and functions
2626 var $that = $(this).addClass( 'mw-collapsible' ), // case: $( '#myAJAXelement' ).makeCollapsible()
@@ -228,7 +228,7 @@
229229
230230 var thatId = $that.attr( 'id' ),
231231 $customTogglers = $( '.' + thatId.replace( 'mw-customcollapsible', 'mw-customtoggle' ) );
232 - mw.log( 'Found custom collapsible: #' + thatId );
 232+ mw.log( _fn + 'Found custom collapsible: #' + thatId );
233233
234234 // Double check that there is actually a customtoggle link
235235 if ( $customTogglers.size() ) {
@@ -236,7 +236,7 @@
237237 toggleLinkCustom( $(this), e, $that );
238238 } );
239239 } else {
240 - mw.log( '#' + thatId + ': Missing toggler!' );
 240+ mw.log( _fn + '#' + thatId + ': Missing toggler!' );
241241 }
242242
243243 // Initial state

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83658Fixing minor issues with mw.loader...krinkle18:49, 10 March 2011

Status & tagging log