r84265 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84264‎ | r84265 | r84266 >
Date:20:58, 18 March 2011
Author:mah
Status:ok
Tags:
Comment:
Followup r83536 to address Jack Phoenix's comments about the bogus w/s “cleanup”
Modified paths:
  • /trunk/phase3/includes/Import.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadBase.php (modified) (history)
  • /trunk/phase3/includes/upload/UploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadBase.php
@@ -1310,7 +1310,7 @@
13111311 global $wgMaxUploadSize;
13121312
13131313 if ( is_array( $wgMaxUploadSize ) ) {
1314 - if ( !is_null( $forType) && isset( $wgMaxUploadSize[$forType] ) ) {
 1314+ if ( !is_null( $forType ) && isset( $wgMaxUploadSize[$forType] ) ) {
13151315 return $wgMaxUploadSize[$forType];
13161316 } else {
13171317 return $wgMaxUploadSize['*'];
Index: trunk/phase3/includes/upload/UploadStash.php
@@ -102,7 +102,7 @@
103103 wfDebug( "UploadStash: tried to stash file at '$path', but it doesn't exist\n" );
104104 throw new UploadStashBadPathException( "path doesn't exist" );
105105 }
106 - $fileProps = File::getPropsFromPath( $path );
 106+ $fileProps = File::getPropsFromPath( $path );
107107
108108 // we will be initializing from some tmpnam files that don't have extensions.
109109 // most of MediaWiki assumes all uploaded files have good extensions. So, we fix this.
Index: trunk/phase3/includes/Import.php
@@ -1072,7 +1072,7 @@
10731073 return false;
10741074 }
10751075
1076 - $user = User::newFromName( $this->user_text );
 1076+ $user = User::newFromName( $this->user_text );
10771077
10781078 $status = $file->upload( $source,
10791079 $this->getComment(),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83536misc w/s cleanups, “svn diff -x-w” cleanmah18:12, 8 March 2011

Status & tagging log