r84244 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84243‎ | r84244 | r84245 >
Date:14:00, 18 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix undefined variable $name by moving code earlier
Modified paths:
  • /trunk/extensions/Configure/scripts/findSettings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/scripts/findSettings.php
@@ -99,12 +99,12 @@
100100 'qp_enable_showresults',
101101 );
102102 foreach ( $exts as $ext ) {
 103+ $name = $ext->getName();
103104 if( !$ext->isInstalled() ) {
104105 $this->output( "Extension $name is not installed\n" );
105106 continue;
106107 }
107108 $file = file_get_contents( $ext->getSettingsFile() );
108 - $name = $ext->getName();
109109 $m = array();
110110 preg_match_all( '/\$((wg|eg|edg|sdg|sfg|smwg|srfg|abc|ce[^n]|ub|whoiswatching|wminc)[A-Za-z0-9_]+)\s*\=/', $file, $m );
111111 $definedSettings = array_unique( $m[1] );

Status & tagging log