r84225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84224‎ | r84225 | r84226 >
Date:02:32, 18 March 2011
Author:tstarling
Status:ok
Tags:
Comment:
MFT r84214: PoolCounter profiling
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/PoolCounter/PoolCounterClient_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/PoolCounter/PoolCounterClient_body.php
@@ -29,9 +29,11 @@
3030 if ( count( $parts ) < 2 ) {
3131 $parts[] = 7531;
3232 }
 33+ wfProfileIn( __METHOD__.'-connect' );
3334 wfSuppressWarnings();
3435 $conn = fsockopen( $parts[0], $parts[1], $errno, $errstr, $this->timeout );
3536 wfRestoreWarnings();
 37+ wfProfileOut( __METHOD__.'-connect' );
3638 if ( $conn ) {
3739 break;
3840 }
@@ -122,20 +124,28 @@
123125 }
124126
125127 function acquireForMe() {
126 - return $this->sendCommand( 'ACQ4ME', $this->key, $this->workers, $this->maxqueue, $this->timeout );
 128+ wfProfileIn( __METHOD__ );
 129+ $status = $this->sendCommand( 'ACQ4ME', $this->key, $this->workers, $this->maxqueue, $this->timeout );
 130+ wfProfileOut( __METHOD__ );
 131+ return $status;
127132 }
128133
129134 function acquireForAnyone() {
130 - return $this->sendCommand( 'ACQ4ANY', $this->key, $this->workers, $this->maxqueue, $this->timeout );
 135+ wfProfileIn( __METHOD__ );
 136+ $status = $this->sendCommand( 'ACQ4ANY', $this->key, $this->workers, $this->maxqueue, $this->timeout );
 137+ wfProfileOut( __METHOD__ );
 138+ return $status;
131139 }
132140
133141 function release() {
 142+ wfProfileIn( __METHOD__ );
134143 $status = $this->sendCommand( 'RELEASE', $this->key );
135144
136145 if ( $this->conn ) {
137146 self::$manager->close( $this->conn );
138147 $this->conn = null;
139148 }
 149+ wfProfileOut( __METHOD__ );
140150 return $status;
141151 }
142152 }
Property changes on: branches/wmf/1.17wmf1/extensions/PoolCounter/PoolCounterClient_body.php
___________________________________________________________________
Added: svn:mergeinfo
143153 Merged /branches/REL1_15/phase3/extensions/PoolCounter/PoolCounterClient_body.php:r51646
144154 Merged /branches/wmf/1.16wmf4/extensions/PoolCounter/PoolCounterClient_body.php:r67177,69199,76243,77266
145155 Merged /trunk/extensions/PoolCounter/PoolCounterClient_body.php:r84214
146156 Merged /branches/sqlite/extensions/PoolCounter/PoolCounterClient_body.php:r58211-58321
147157 Merged /trunk/phase3/extensions/PoolCounter/PoolCounterClient_body.php:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,81833,83212,83590
148158 Merged /branches/new-installer/phase3/extensions/PoolCounter/PoolCounterClient_body.php:r43664-66004
149159 Merged /branches/wmf-deployment/extensions/PoolCounter/PoolCounterClient_body.php:r60970

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84214Profiling sections for network operationststarling23:16, 17 March 2011

Status & tagging log