r84172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84171‎ | r84172 | r84173 >
Date:15:40, 17 March 2011
Author:aaron
Status:ok
Tags:
Comment:
Fixed silly bug in r84170
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -619,7 +619,7 @@
620620 }
621621 # All cases below require auto-review of edits to be enabled
622622 if ( !FlaggedRevs::autoReviewEnabled() ) {
623 - return true;
 623+ return true; // short-circuit
624624 }
625625 # If a $baseRevId is passed in, the edit is using an old revision's text
626626 $isOldRevCopy = (bool)$baseRevId; // null edit or rollback
@@ -670,7 +670,7 @@
671671 # (a) this is a rollback to the stable version
672672 # (b) this is a self-reversion to the stable version
673673 # These are subcases of making a new revision based on an old, reviewed, revision.
674 - } elseif ( $fa->getStableRev( FR_MASTER ) ) {
 674+ } elseif ( FlaggedRevs::autoReviewEdits() && $fa->getStableRev( FR_MASTER ) ) {
675675 $srev = $fa->getStableRev();
676676 # Check for rollbacks...
677677 $reviewableChange = (

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84170* Combined $wgFlaggedRevsAutoReview/$wgFlaggedRevsAutoReviewNew into just $wg...aaron15:20, 17 March 2011

Status & tagging log