r84148 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84147‎ | r84148 | r84149 >
Date:04:42, 17 March 2011
Author:bawolff
Status:ok
Tags:
Comment:
Renamed $param['nameSpace'] -> $param['namespace']. I suppose its not wrong,
but it was annoying me a little bit.

Probably should of included this in my last commit...
Modified paths:
  • /trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GoogleNewsSitemap/GoogleNewsSitemap_body.php
——@@ -260,8 +260,8 @@
261261 $fields = array( 'page_namespace', 'page_title', 'page_id', 'c1.cl_timestamp' );
262262 $conditions = array();
263263
264 - if ( $params['nameSpace'] !== false ) {
265 - $conditions['page_namespace'] = $params['nameSpace'];
 264+ if ( $params['namespace'] !== false ) {
 265+ $conditions['page_namespace'] = $params['namespace'];
266266 }
267267
268268 // If flagged revisions is in use, check which options selected.
——@@ -376,7 +376,7 @@
377377 $categories = $this->getCatRequestArray( 'categories', $wgGNSMfallbackCategory, $wgGNSMmaxCategories );
378378 $notCategories = $this->getCatRequestArray( 'notcategories', '', $wgGNSMmaxCategories );
379379
380 - $params['nameSpace'] = $this->getNS( $wgRequest->getVal( 'namespace', 0 ) );
 380+ $params['namespace'] = $this->getNS( $wgRequest->getVal( 'namespace', 0 ) );
381381
382382 $params['count'] = $wgRequest->getInt( 'count', $wgGNSMmaxResultCount );
383383 $params['hourCount'] = $wgRequest->getInt( 'hourcount', -1 );

Status & tagging log