r84083 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84082‎ | r84083 | r84084 >
Date:09:05, 16 March 2011
Author:ialex
Status:ok
Tags:
Comment:
Removed usage of extract() in LinkHolderArray::doVariants()
Modified paths:
  • /trunk/phase3/includes/parser/LinkHolderArray.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/LinkHolderArray.php
@@ -461,14 +461,13 @@
462462 for ( $i = 0; $i < $l; $i ++ ) {
463463 foreach ( $allVariantsName as $variantName ) {
464464 $textVariant = $titlesAllVariants[$variantName][$i];
465 - extract( $titlesAttrs[$i] );
466 - if($textVariant != $titleText){
467 - $variantTitle = Title::makeTitle( $ns, $textVariant );
 465+ if ( $textVariant != $titlesAttrs[$i]['titleText'] ) {
 466+ $variantTitle = Title::makeTitle( $titlesAttrs[$i]['ns'], $textVariant );
468467 if( is_null( $variantTitle ) ) {
469468 continue;
470469 }
471470 $linkBatch->addObj( $variantTitle );
472 - $variantMap[$variantTitle->getPrefixedDBkey()][] = $key;
 471+ $variantMap[$variantTitle->getPrefixedDBkey()][] = $titlesAttrs[$i]['key'];
473472 }
474473 }
475474 }

Status & tagging log