r84065 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84064‎ | r84065 | r84066 >
Date:22:56, 15 March 2011
Author:yaron
Status:deferred
Tags:
Comment:
Fixed setting of form title for forms with no target page (broken in r83967); improved wording of title
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
@@ -149,7 +149,9 @@
150150 // title - this needs to be done after formHTML() is
151151 // called, because otherwise it doesn't take hold
152152 // for some reason if the form is disabled.
153 - if ( $target_title->exists() ) {
 153+ if ( empty( $target_title ) ) {
 154+ $s = wfMsg( 'sf_formedit_createtitlenotarget', $form_title->getText() );
 155+ } elseif ( $target_title->exists() ) {
154156 $s = wfMsg( 'sf_formedit_edittitle', $form_title->getText(), $target_title->getPrefixedText() );
155157 } else {
156158 $s = wfMsg( 'sf_formedit_createtitle', $form_title->getText(), $target_title->getPrefixedText() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83967Fixed display of form title when form is disabledyaron21:17, 14 March 2011