r84051 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84050‎ | r84051 | r84052 >
Date:20:08, 15 March 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
work on map input js
Modified paths:
  • /branches/SemanticMaps0.8/includes/services/GoogleMaps3/jquery.googlemapsinput.js (modified) (history)
  • /branches/SemanticMaps0.8/includes/services/OpenLayers/jquery.openlayersinput.js (modified) (history)

Diff [purge]

Index: branches/SemanticMaps0.8/includes/services/GoogleMaps3/jquery.googlemapsinput.js
@@ -14,7 +14,11 @@
1515 var self = this;
1616
1717 this.showCoordinate = function( coordinate ) {
18 -
 18+ this.mapDiv.removeMarkers();
 19+ coordinate.icon = '';
 20+ coordinate.title = '';
 21+ coordinate.text = coord.dms( coordinate.lat, coordinate.lon );
 22+ this.mapDiv.addMarker( coordinate );
1923 };
2024
2125 this.geocodeAddress = function( address ) {
Index: branches/SemanticMaps0.8/includes/services/OpenLayers/jquery.openlayersinput.js
@@ -15,6 +15,7 @@
1616
1717 /**
1818 * @param {OpenLayers.LonLat} location
 19+ * @param {string} title
1920 */
2021 this.showLocation = function( location, title ) {
2122 var markerLayer = self.mapDiv.map.getLayer('markerLayer');

Status & tagging log