r84008 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84007‎ | r84008 | r84009 >
Date:12:00, 15 March 2011
Author:reedy
Status:ok
Tags:
Comment:
After r83879, we're requiring php 5.2.3

Remove < 5.1.7 check and related code
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.php
@@ -694,10 +694,6 @@
695695 $this->postData = wfArrayToCGI( $this->postData );
696696 }
697697
698 - // At least on Centos 4.8 with PHP 5.1.6, using max_redirects to follow redirects
699 - // causes a segfault
700 - $manuallyRedirect = version_compare( phpversion(), '5.1.7', '<' );
701 -
702698 if ( $this->parsedUrl['scheme'] != 'http' ) {
703699 $this->status->fatal( 'http-invalid-scheme', $this->parsedUrl['scheme'] );
704700 }
@@ -715,7 +711,7 @@
716712 $options['request_fulluri'] = true;
717713 }
718714
719 - if ( !$this->followRedirects || $manuallyRedirect ) {
 715+ if ( !$this->followRedirects ) {
720716 $options['max_redirects'] = 0;
721717 } else {
722718 $options['max_redirects'] = $this->maxRedirects;
@@ -765,7 +761,7 @@
766762 $this->headerList = $result['wrapper_data'];
767763 $this->parseHeader();
768764
769 - if ( !$manuallyRedirect || !$this->followRedirects ) {
 765+ if ( !$this->followRedirects ) {
770766 break;
771767 }
772768

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83879Require at least PHP 5.2.3. There's not much point increasing the minimum to ...tstarling10:42, 14 March 2011

Status & tagging log