r83980 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83979‎ | r83980 | r83981 >
Date:23:44, 14 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Trim/fix whitespace
Modified paths:
  • /trunk/extensions/TitleBlacklist/TitleBlacklist.list.php (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES
@@ -193,7 +193,7 @@
194194 for "ABORTED" reason to be returned and displayed to user.
195195 * (bug 28034) uploading file to local wiki when file exists on shared repository
196196 (commons) gives spurious info in the warning message
197 -
 197+
198198 === API changes in 1.18 ===
199199 * (bug 26339) Throw warning when truncating an overlarge API result
200200 * (bug 14869) Add API module for accessing QueryPage-based special pages
Index: trunk/extensions/TitleBlacklist/TitleBlacklist.list.php
@@ -21,7 +21,7 @@
2222
2323 /**
2424 * Load all configured blacklist sources
25 - */
 25+ */
2626 public function load() {
2727 global $wgTitleBlacklistSources, $wgMemc, $wgTitleBlacklistCaching;
2828 wfProfileIn( __METHOD__ );
@@ -46,7 +46,7 @@
4747
4848 /**
4949 * Load all configured whitelist sources
50 - */
 50+ */
5151 public function loadWhitelist() {
5252 global $wgMemc, $wgTitleBlacklistCaching;
5353 wfProfileIn( __METHOD__ );
@@ -66,7 +66,7 @@
6767 *
6868 * @param $source A blacklist source from $wgTitleBlacklistSources
6969 * @return The content of the blacklist source as a string
70 - */
 70+ */
7171 private static function getBlacklistText( $source ) {
7272 if( !is_array( $source ) || count( $source ) <= 0 ) {
7373 return ''; //Return empty string in error case
@@ -111,7 +111,7 @@
112112 *
113113 * @param $list Text of a blacklist source, as a string
114114 * @return An array of TitleBlacklistEntry entries
115 - */
 115+ */
116116 public static function parseBlacklist( $list ) {
117117 wfProfileIn( __METHOD__ );
118118 $lines = preg_split( "/\r?\n/", $list );
@@ -138,7 +138,7 @@
139139 * @param $override If set to true, overrides work
140140 * @return The corresponding TitleBlacklistEntry if blacklisted;
141141 * otherwise FALSE
142 - */
 142+ */
143143 public function userCannot( $title, $user, $action = 'edit', $override = true ) {
144144 if( $override && self::userCanOverride( $action ) )
145145 return false;
@@ -154,7 +154,7 @@
155155 * @param $action Action to check; 'edit' if unspecified
156156 * @return The corresponding TitleBlacklistEntry if blacklisted;
157157 * otherwise FALSE
158 - */
 158+ */
159159 public function isBlacklisted( $title, $action = 'edit' ) {
160160 if( !($title instanceof Title) ) {
161161 $title = Title::newFromText( $title );
@@ -178,7 +178,7 @@
179179 * @param $title Title to check
180180 * @param $action Action to check; 'edit' if unspecified
181181 * @return TRUE if whitelisted; otherwise FALSE
182 - */
 182+ */
183183 public function isWhitelisted( $title, $action = 'edit' ) {
184184 global $wgUser;
185185 if( !($title instanceof Title) ) {
@@ -197,7 +197,7 @@
198198 * Get the current blacklist
199199 *
200200 * @return Array of TitleBlacklistEntry items
201 - */
 201+ */
202202 public function getBlacklist() {
203203 if( is_null( $this->mBlacklist ) ) {
204204 $this->load();
@@ -209,7 +209,7 @@
210210 * Get the current whitelist
211211 *
212212 * @return Array of TitleBlacklistEntry items
213 - */
 213+ */
214214 public function getWhitelist() {
215215 if( is_null( $this->mWhitelist ) ) {
216216 $this->loadWhitelist();
@@ -222,7 +222,7 @@
223223 *
224224 * @param $source URL of the blacklist source
225225 * @return The content of the blacklist source as a string
226 - */
 226+ */
227227 private static function getHttp( $url ) {
228228 global $messageMemc, $wgTitleBlacklistCaching;
229229 $key = "title_blacklist_source:" . md5( $url ); // Global shared

Status & tagging log