r83971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83970‎ | r83971 | r83972 >
Date:22:20, 14 March 2011
Author:laner
Status:deferred
Tags:
Comment:
Reverting r83317. Passing by reference here is required by the library.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaUser.php
@@ -344,10 +344,10 @@
345345 */
346346 static function uuid4() {
347347 $uuid = '';
348 - uuid_create( $uuid );
 348+ uuid_create( &$uuid );
349349 uuid_make( $uuid, UUID_MAKE_V4 );
350350 $uuidExport = '';
351 - uuid_export( $uuid, UUID_FMT_STR, $uuidExport );
 351+ uuid_export( $uuid, UUID_FMT_STR, &$uuidExport );
352352 return trim( $uuidExport );
353353 }
354354

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83317Fix E_DEPRECATEDmaxsem19:45, 5 March 2011

Status & tagging log