r83969 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83968‎ | r83969 | r83970 >
Date:21:42, 14 March 2011
Author:dale
Status:ok
Tags:
Comment:
added mwe-upwiz-skip-tutorial-future msg key instead of hard coding the message
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.i18n.php
@@ -83,6 +83,7 @@
8484 'mwe-upwiz-file-some-failed' => 'Some uploads failed.',
8585 'mwe-upwiz-file-retry' => 'Retry failed uploads',
8686 'mwe-upwiz-next-file-despite-failures' => 'Continue anyway',
 87+ 'mwe-upwiz-skip-tutorial-future' => 'Skip this step in the future',
8788 'mwe-upwiz-file-all-failed' => 'None of the uploads were successful.',
8889 'mwe-upwiz-upload-count' => '$1 of $2 {{PLURAL:$2|file|files}} uploaded',
8990 'mwe-upwiz-progressbar-uploading' => 'uploading',
Index: trunk/extensions/UploadWizard/SpecialUploadWizard.php
@@ -177,10 +177,12 @@
178178 function getWizardHtml() {
179179 $tutorialHtml = '';
180180 // only load the tutorial HTML if we aren't skipping the first step
 181+ // TODO should use user preference not a cookie ( so the user does not have to skip it for every browser )
181182 if ( !isset( $_COOKIE['skiptutorial'] ) ) {
182183 $tutorialHtml = UploadWizardTutorial::getHtml();
183184 }
184 - // TODO loading spinner, hide these by default till enhanced?
 185+ // TODO move this into UploadWizard.js or some other javascript resource so the upload wizard
 186+ // can be dynamically included ( for example the add media wizard )
185187 return
186188 '<div id="upload-wizard" class="upload-section">'
187189
@@ -202,7 +204,7 @@
203205 . '</div>'
204206 . '<div class="mwe-upwiz-buttons">'
205207 . '<input type="checkbox" id="mwe-upwiz-skip" value="1" name="skip">'
206 - . '<label for="mwe-upwiz-skip">Skip this step in the future</label>'
 208+ . '<label for="mwe-upwiz-skip">' . wfMsg('mwe-upwiz-skip-tutorial-future') . '</label>'
207209 . '<button class="mwe-upwiz-button-next">' . wfMsg( "mwe-upwiz-next" ) . '</button>'
208210 . '</div>'
209211 . '</div>'

Status & tagging log