r83933 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83932‎ | r83933 | r83934 >
Date:17:59, 14 March 2011
Author:saper
Status:ok
Tags:
Comment:
Followup to r81507: Call to undefined method StandardTemplate::showEmailUser()

Fixes:

PHP Fatal error: Call to undefined method StandardTemplate::showEmailUser() in skins/Standard.php on line 262
Modified paths:
  • /trunk/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Standard.php
——@@ -259,7 +259,7 @@
260260 if( $id || $ip ){
261261 $s .= $sep . $this->userContribsLink();
262262 }
263 - if( $this->showEmailUser( $id ) ) {
 263+ if( $this->getSkin()->showEmailUser( $id ) ) {
264264 $s .= $sep . $this->emailUserLink();
265265 }
266266 }

Sign-offs

UserFlagDate
Dantmaninspected18:11, 14 March 2011
Krinkleinspected00:06, 18 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81507Completely remove support for legacy style skins. All legacy skinning options...dantman04:18, 4 February 2011

Status & tagging log