r83912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83911‎ | r83912 | r83913 >
Date:16:15, 14 March 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r83910
Modified paths:
  • /branches/SemanticMaps0.8/SM_Settings.php (modified) (history)
  • /branches/SemanticMaps0.8/includes/services/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /branches/SemanticMaps0.8/includes/services/OpenLayers/jquery.openlayersinput.js (modified) (history)

Diff [purge]

Index: branches/SemanticMaps0.8/SM_Settings.php
@@ -70,8 +70,6 @@
7171
7272 $smgFIFieldSize = 40;
7373
74 - $smgFiGeoNamesUser = '';
75 -
7674 # Integer or string. The default width and height of maps in forms created by using Semantic Forms.
7775 # These values only be used when the user does not provide them.
7876 $smgFIWidth = 665;
Index: branches/SemanticMaps0.8/includes/services/OpenLayers/SM_OpenLayersFormInput.php
@@ -32,9 +32,9 @@
3333 * @return mixed
3434 */
3535 protected function getJSONObject( array $params, Parser $parser ) {
36 - global $smgFiGeoNamesUser;
 36+ global $egMapsGeoNamesUser;
3737
38 - $params['geonamesusername'] = $smgFiGeoNamesUser;
 38+ $params['geonamesusername'] = $egMapsGeoNamesUser;
3939
4040 return $params;
4141 }
Index: branches/SemanticMaps0.8/includes/services/OpenLayers/jquery.openlayersinput.js
@@ -130,7 +130,7 @@
131131 {
132132 'q': address,
133133 'username': options.geonamesusername,
134 - 'formatted': 'true',
 134+ //'formatted': 'true',
135135 'maxRows': 1
136136 },
137137 function( data ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83910updating geonames geocoderjeroendedauw16:09, 14 March 2011

Status & tagging log