r83893 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83892‎ | r83893 | r83894 >
Date:13:31, 14 March 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
match r83892
Modified paths:
  • /branches/Maps0.8/Maps.i18n.php (modified) (history)
  • /branches/Maps0.8/Maps.php (modified) (history)

Diff [purge]

Index: branches/Maps0.8/Maps.i18n.php
@@ -15,9 +15,7 @@
1616 */
1717 $messages['en'] = array(
1818 // General
19 - 'maps_name' => 'Maps',
20 - 'maps_desc' => "Provides the ability to display coordinate data in maps, and geocode addresses ([http://mapping.referata.com/wiki/Maps_examples demo's]).
21 -Available mapping services: $1",
 19+ 'maps-desc' => "Enables embedding of dynamic maps into wiki pages, geocoding of addresses and other geographical operations. ([http://mapping.referata.com/wiki/Examples demos])",
2220 'maps_map' => 'Map',
2321 'maps-loading-map' => 'Loading map...',
2422 'maps-load-failed' => 'Could not load the map!',
Index: branches/Maps0.8/Maps.php
@@ -43,6 +43,17 @@
4444
4545 define( 'Maps_VERSION', '0.8 alpha' );
4646
 47+$wgExtensionCredits['parserhook'][] = array(
 48+ 'path' => __FILE__,
 49+ 'name' => 'Maps',
 50+ 'version' => Maps_VERSION,
 51+ 'author' => array(
 52+ '[http://www.mediawiki.org/wiki/User:Jeroen_De_Dauw Jeroen De Dauw]'
 53+ ),
 54+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Maps',
 55+ 'descriptionmsg' => 'maps-desc'
 56+);
 57+
4758 // The different coordinate notations.
4859 define( 'Maps_COORDS_FLOAT', 'float' );
4960 define( 'Maps_COORDS_DMS', 'dms' );
@@ -234,7 +245,7 @@
235246 * @return true
236247 */
237248 function efMapsSetup() {
238 - global $wgExtensionCredits, $wgLang, $wgExtraNamespaces, $wgNamespaceAliases;
 249+ global $wgExtraNamespaces, $wgNamespaceAliases;
239250
240251 if ( is_null( $wgExtraNamespaces ) ) {
241252 $wgExtraNamespaces = array();
@@ -253,21 +264,5 @@
254265 wfRunHooks( 'MappingServiceLoad' );
255266 wfRunHooks( 'MappingFeatureLoad' );
256267
257 - // Creation of a list of internationalized service names.
258 - $services = array();
259 - foreach ( MapsMappingServices::getServiceIdentifiers() as $identifier ) $services[] = wfMsg( 'maps_' . $identifier );
260 - $servicesList = $wgLang->listToText( $services );
261 -
262 - $wgExtensionCredits['parserhook'][] = array(
263 - 'path' => __FILE__,
264 - 'name' => wfMsg( 'maps_name' ),
265 - 'version' => Maps_VERSION,
266 - 'author' => array(
267 - '[http://www.mediawiki.org/wiki/User:Jeroen_De_Dauw Jeroen De Dauw]'
268 - ),
269 - 'url' => 'http://www.mediawiki.org/wiki/Extension:Maps',
270 - 'description' => wfMsgExt( 'maps_desc', 'parsemag', $servicesList ),
271 - );
272 -
273268 return true;
274269 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83892fix i18n weirdness causing other extensions to fail registering hooks (wtf?)jeroendedauw13:30, 14 March 2011

Status & tagging log