r83880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83879‎ | r83880 | r83881 >
Date:11:05, 14 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Partial revert r83845, use indexed fields for join
Modified paths:
  • /trunk/phase3/includes/specials/SpecialActiveusers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialActiveusers.php
@@ -106,7 +106,7 @@
107107 'USE INDEX' => array( 'recentchanges' => 'rc_user_text' )
108108 ),
109109 'join_conds' => array(
110 - 'user' => array( 'INNER JOIN', 'rc_user=user_id' ),
 110+ 'user' => array( 'INNER JOIN', 'rc_user_text=user_name' ),
111111 'ipblocks' => array( 'LEFT JOIN', 'user_id=ipb_user AND ipb_auto=0 AND ipb_deleted=1' ),
112112 ),
113113 'conds' => $conds

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83845Join user table to recentchanges on user id, rather than user_text...reedy18:23, 13 March 2011

Status & tagging log