r83796 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83795‎ | r83796 | r83797 >
Date:23:22, 12 March 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r83786: update references in SpecialPage::getTitleFor() and friends to point to 'Block' rather than 'Blockip'; should fix errors on translatewiki.
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialDeletedContributions.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -942,7 +942,7 @@
943943 * @private
944944 */
945945 function blockLink( $userId, $userText ) {
946 - $blockPage = SpecialPage::getTitleFor( 'Blockip', $userText );
 946+ $blockPage = SpecialPage::getTitleFor( 'Block', $userText );
947947 $blockLink = $this->link( $blockPage, wfMsgHtml( 'blocklink' ) );
948948 return $blockLink;
949949 }
Index: trunk/phase3/includes/LogEventsList.php
@@ -411,7 +411,7 @@
412412 ) .
413413 $this->message['pipe-separator'] .
414414 $this->skin->link(
415 - SpecialPage::getTitleFor( 'Blockip', $row->log_title ),
 415+ SpecialPage::getTitleFor( 'Block', $row->log_title ),
416416 $this->message['change-blocklink'],
417417 array(),
418418 array(),
Index: trunk/phase3/includes/SkinTemplate.php
@@ -1224,7 +1224,7 @@
12251225
12261226 if ( $wgUser->isAllowed( 'block' ) ) {
12271227 $nav_urls['blockip'] = array(
1228 - 'href' => self::makeSpecialUrlSubpage( 'Blockip', $rootUser )
 1228+ 'href' => self::makeSpecialUrlSubpage( 'Block', $rootUser )
12291229 );
12301230 } else {
12311231 $nav_urls['blockip'] = false;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -4942,7 +4942,7 @@
49434943 'Listadmins' => 'users',
49444944 'Listbots' => 'users',
49454945 'Userrights' => 'users',
4946 - 'Blockip' => 'users',
 4946+ 'Block' => 'users',
49474947 'Preferences' => 'users',
49484948 'Resetpass' => 'users',
49494949 'DeletedContributions' => 'users',
Index: trunk/phase3/includes/specials/SpecialIpblocklist.php
@@ -498,7 +498,7 @@
499499 # Create changeblocklink for all blocks with exception of autoblocks
500500 if( !$block->mAuto ) {
501501 $changeblocklink = wfMsgExt( 'pipe-separator', 'escapenoentities' ) .
502 - $sk->link( SpecialPage::getTitleFor( 'Blockip', $block->mAddress ),
 502+ $sk->link( SpecialPage::getTitleFor( 'Block', $block->mAddress ),
503503 $msg['change-blocklink'],
504504 array(), array(), 'known' );
505505 }
Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -252,7 +252,7 @@
253253 if( $subject->isAllowed( 'block' ) ) { # Block / Change block / Unblock links
254254 if ( $target->isBlocked() ) {
255255 $tools[] = $sk->linkKnown( # Change block link
256 - SpecialPage::getTitleFor( 'Blockip', $username ),
 256+ SpecialPage::getTitleFor( 'Block', $username ),
257257 wfMsgHtml( 'change-blocklink' )
258258 );
259259 $tools[] = $sk->linkKnown( # Unblock link
@@ -266,7 +266,7 @@
267267 );
268268 } else { # User is not blocked
269269 $tools[] = $sk->linkKnown( # Block link
270 - SpecialPage::getTitleFor( 'Blockip', $username ),
 270+ SpecialPage::getTitleFor( 'Block', $username ),
271271 wfMsgHtml( 'blocklink' )
272272 );
273273 }
Index: trunk/phase3/includes/specials/SpecialDeletedContributions.php
@@ -372,7 +372,7 @@
373373 if( $wgUser->isAllowed( 'block' ) ) { # Block / Change block / Unblock links
374374 if ( $userObj->isBlocked() ) {
375375 $tools[] = $sk->linkKnown( # Change block link
376 - SpecialPage::getTitleFor( 'Blockip', $nt->getDBkey() ),
 376+ SpecialPage::getTitleFor( 'Block', $nt->getDBkey() ),
377377 wfMsgHtml( 'change-blocklink' )
378378 );
379379 $tools[] = $sk->linkKnown( # Unblock link
@@ -387,7 +387,7 @@
388388 }
389389 else { # User is not blocked
390390 $tools[] = $sk->linkKnown( # Block link
391 - SpecialPage::getTitleFor( 'Blockip', $nt->getDBkey() ),
 391+ SpecialPage::getTitleFor( 'Block', $nt->getDBkey() ),
392392 wfMsgHtml( 'blocklink' )
393393 );
394394 }
Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -432,7 +432,7 @@
433433 if ( !$dbr->numRows( $ret ) ) {
434434 $s = $this->noMatchesMessage( $user ) . "\n";
435435 } else {
436 - $blockip = SpecialPage::getTitleFor( 'Blockip' );
 436+ $blockip = SpecialPage::getTitleFor( 'Block' );
437437 $ips_edits = array();
438438 $counter = 0;
439439 foreach ( $ret as $row ) {
Index: trunk/extensions/ConfirmAccount/ConfirmAccount_body.php
@@ -325,7 +325,7 @@
326326 $form .= self::parseLinks($row->acr_urls);
327327 }
328328 if( $wgUser->isAllowed( 'requestips' ) ) {
329 - $blokip = SpecialPage::getTitleFor( 'Blockip' );
 329+ $blokip = SpecialPage::getTitleFor( 'Block' );
330330 $form .= "<p>".wfMsgHtml('confirmaccount-ip')." ".htmlspecialchars($row->acr_ip).
331331 " (" . $this->skin->makeKnownLinkObj( $blokip, wfMsgHtml('blockip'),
332332 'ip=' . $row->acr_ip . '&wpCreateAccount=1' ).")</p>\n";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83786Divert a river through the Augean Stables that is SpecialBlockip.php....happy-melon21:54, 12 March 2011

Status & tagging log