r83693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83692‎ | r83693 | r83694 >
Date:03:00, 11 March 2011
Author:laner
Status:deferred
Tags:
Comment:
* Removing 'Allocate IP Addresses' from SpecialInstances; I agree it would be nice to have this navigation from this page, just not from this location.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackManager.i18n.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php
@@ -487,7 +487,6 @@
488488 $out .= Html::element( 'h2', array(), $project );
489489 $out .= $sk->link( $this->getTitle(), wfMsgHtml( 'openstackmanager-createinstance' ), array(),
490490 array( 'action' => 'create', 'project' => $project ) );
491 - $out .= ' ' . $sk->link( Special::getTitleFor( 'NovaAddress' ), wfMsgHtml( 'openstackmanager-allocateips' ) );
492491 if ( isset( $projectArr["$project"] ) ) {
493492 $projectOut = $header;
494493 $projectOut .= $projectArr["$project"];
Index: trunk/extensions/OpenStackManager/OpenStackManager.i18n.php
@@ -88,7 +88,6 @@
8989 'openstackmanager-instancetypelabel' => '{{PLURAL:$1|$1 CPU|$1 CPUs}}, $2 MB RAM, $3 GB storage',
9090 'openstackmanager-launchtime' => 'Launch time',
9191 'openstackmanager-createinstance' => 'Create a new instance',
92 - 'openstackmanager-allocateips' => 'Allocate IP addresses',
9392 'openstackmanager-invaliddomain' => 'Requested domain is invalid.',
9493 'openstackmanager-createdinstance' => 'Created instance $1 with image $2 and hostname $3.',
9594 'openstackmanager-createfailedldap' => 'Failed to create instance as the host could not be added to LDAP.',

Status & tagging log