r83687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83686‎ | r83687 | r83688 >
Date:01:46, 11 March 2011
Author:neilk
Status:deferred
Tags:
Comment:
fixed docs
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.Utilities.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.Utilities.js
@@ -3,30 +3,29 @@
44 ( function( mw ) {
55
66 /**
7 - * Check if a value is null, undefined, or the empty string.
8 - *
9 - * @param {Object} object Object to be checked
10 - * @return {Boolean}
11 - */
 7+ * Check if a value is null, undefined, or the empty string.
 8+ *
 9+ * @param {object} object Object to be checked
 10+ * @return {boolean}
 11+ */
1212 mw.isEmpty = function( o ) {
1313 return ! mw.isDefined( o ) || o === null || ( typeof o === 'string' && o === '' );
1414 };
1515
1616 /**
1717 * Check if something is defined
18 - * (inlineable?)
19 - * @param {Object}
20 - * @return boolean
 18+ * @param {object}
 19+ * @return {boolean}
2120 */
22 - mw.isDefined = function( obj ) {
23 - return typeof obj !== 'undefined';
 21+ mw.isDefined = function( o ) {
 22+ return typeof o !== 'undefined';
2423 };
2524
2625
2726 /**
2827 * Upper-case the first letter of a string.
29 - * @param string
30 - * @return string with first letter uppercased.
 28+ * @param {string}
 29+ * @return {string} with first letter uppercased.
3130 */
3231 mw.ucfirst = function( s ) {
3332 return s.substring(0,1).toUpperCase() + s.substr(1);

Status & tagging log