r83681 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83680‎ | r83681 | r83682 >
Date:00:21, 11 March 2011
Author:rfaulk
Status:deferred
Tags:
Comment:
altered password access to reporting forms.
Modified paths:
  • /trunk/fundraiser-statistics/reporting/banner_test_proc.php (modified) (history)
  • /trunk/fundraiser-statistics/reporting/compare_test.php (modified) (history)
  • /trunk/fundraiser-statistics/reporting/custom_campaign_plot.php (modified) (history)
  • /trunk/fundraiser-statistics/reporting/donor_history_proc.php (modified) (history)

Diff [purge]

Index: trunk/fundraiser-statistics/reporting/donor_history_proc.php
@@ -9,7 +9,11 @@
1010 // Authenticate form
1111 $pwd_key=$_POST["pwd"];
1212
13 -if ($pwd_key != "angelface") {
 13+// extract the private the passkey
 14+$key_string = file_get_contents ("keys.txt");
 15+$key_string = trim($key_string);
 16+
 17+if ($pwd_key != $key_string) {
1418 $message = "Invalid Key.\n";
1519 die($message);
1620 }
Index: trunk/fundraiser-statistics/reporting/compare_test.php
@@ -9,7 +9,11 @@
1010 // Authenticate form
1111 $pwd_key=$_POST["pwd"];
1212
13 -if ($pwd_key != "angelface") {
 13+// extract the private the passkey
 14+$key_string = file_get_contents ("keys.txt");
 15+$key_string = trim($key_string);
 16+
 17+if ($pwd_key != $key_string) {
1418 $message = "Invalid Key.\n";
1519 die($message);
1620 }
Index: trunk/fundraiser-statistics/reporting/banner_test_proc.php
@@ -9,7 +9,11 @@
1010 // Authenticate form
1111 $pwd_key=$_POST["pwd"];
1212
13 -if ($pwd_key != "angelface") {
 13+// extract the private the passkey
 14+$key_string = file_get_contents ("keys.txt");
 15+$key_string = trim($key_string);
 16+
 17+if ($pwd_key != $key_string) {
1418 $message = "Invalid Key.\n";
1519 die($message);
1620 }
@@ -49,7 +53,7 @@
5054 $query = sprintf($query, $start, $end, $cmpgn, $start, $end, $cmpgn);
5155 } elseif ($sql_file == "landing_page_test_by_hour.sql") {
5256 $query = sprintf($query, "%", "%", "%", "%", $start, $end, $cmpgn, "%", "%", "%", "%", $start, $end, $cmpgn);
53 -} elseif ($sql_file == "ecomm_test.sql") {
 57+} elseif ($sql_file == "ecomm_test.sql" || $sql_file == "ecomm_test_by_banner.sql" || $sql_file == "ecomm_test_by_lp.sql") {
5458 $query = sprintf($query, $start, $end, $cmpgn);
5559 } elseif ($sql_file == "ecomm_test_by_hour.sql") {
5660 $query = sprintf($query, "%", "%", "%", "%", $start, $end, $cmpgn);
Index: trunk/fundraiser-statistics/reporting/custom_campaign_plot.php
@@ -10,7 +10,11 @@
1111 // Authenticate form
1212 $pwd_key=$_POST["pwd"];
1313
14 -if ($pwd_key != "angelface") {
 14+// extract the private the passkey
 15+$key_string = file_get_contents ("keys.txt");
 16+$key_string = trim($key_string);
 17+
 18+if ($pwd_key != $key_string) {
1519 $message = "Invalid Key.\n";
1620 die($message);
1721 }

Status & tagging log