r83676 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83675‎ | r83676 | r83677 >
Date:23:01, 10 March 2011
Author:demon
Status:ok
Tags:
Comment:
Fix for r81071, still one $mAuthor left.
Another fix like r83550 where we didn't make sure $revisionAuthor existed
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -388,7 +388,7 @@
389389 $committer = $commitAuthor->getName();
390390 $commitAuthorId = $commitAuthor->getId();
391391 } else {
392 - $committer = htmlspecialchars( $this->mAuthor );
 392+ $committer = htmlspecialchars( $this->author );
393393 $commitAuthorId = 0;
394394 }
395395
@@ -428,7 +428,7 @@
429429 $revisionCommitSummary = $revision->getMessage();
430430
431431 //Add the followup revision author if they have not already been added as a commentor (they won't want dupe emails!)
432 - if ( !array_key_exists( $revisionAuthor->getId(), $users ) ) {
 432+ if ( $revisionAuthor && !array_key_exists( $revisionAuthor->getId(), $users ) ) {
433433 $users[$revisionAuthor->getId()] = $revisionAuthor;
434434 }
435435

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81071CodeRevision: Switch data members to protected, add missing get method. Renam...reedy23:37, 26 January 2011
r83550Fix stupid fatal where wiki user isn't attached/doesn't existreedy23:07, 8 March 2011

Status & tagging log