r83666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83665‎ | r83666 | r83667 >
Date:20:33, 10 March 2011
Author:hashar
Status:ok
Tags:
Comment:
makes it clear to the user that the diff error message is an error

fu 83345
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiCodeDiff.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiCodeDiff.php
@@ -42,7 +42,7 @@
4343
4444 if ( !is_string( $diff ) ) {
4545 // FIXME: Are we sure we don't want to throw an error here?
46 - $html = 'Failed to load diff. ' . CodeRepository::getDiffErrorMessage( $diff );
 46+ $html = 'Failed to load diff. Error message: ' . CodeRepository::getDiffErrorMessage( $diff );
4747 } elseif ( strlen( $diff ) > $wgCodeReviewMaxDiffSize ) {
4848 $html = 'Diff too large.';
4949 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83345Give a bit more information about why diff failedreedy00:45, 6 March 2011

Status & tagging log