r83663 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83662‎ | r83663 | r83664 >
Date:19:47, 10 March 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
bugfix for missing scrollbar in IE7
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SF_popupform.js (modified) (history)
  • /trunk/extensions/SemanticForms/skins/SF_popupform.css (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/skins/SF_popupform.css
@@ -71,20 +71,20 @@
7272
7373 div.popupform-loadingbg {
7474 position: absolute;
75 - left: -63px;
76 - top: -63px;
77 - width: 127px;
78 - height: 127px;
 75+ left: -64px;
 76+ top: -64px;
 77+ width: 128px;
 78+ height: 128px;
7979 background-color: transparent;
8080 background-image: url('../skins/loadingbg.png');
8181 }
8282
8383 div.popupform-loadingfg {
8484 position: absolute;
85 - left: -15px;
86 - top: -15px;
87 - width: 30px;
88 - height: 30px;
 85+ left: -16px;
 86+ top: -16px;
 87+ width: 32px;
 88+ height: 32px;
8989 background-color: transparent;
9090 background-image: url('../skins/loading.gif');
9191 }
Index: trunk/extensions/SemanticForms/libs/SF_popupform.js
@@ -250,7 +250,8 @@
251251 siblings
252252 .each( function(){
253253 var elem = jQuery(this);
254 - // if ( ( elem.outerWidth(true) > 0 && elem.outerHeight(true) > 0 ) &&
 254+
 255+ // TODO: Does this really help?
255256 if ( getStyle(this, "display") != "none"
256257 && ( getStyle( this, "width") != "0px" || getStyle( this, "height") != "0px" )
257258 && ! (
@@ -301,10 +302,6 @@
302303 var innerwdw = window.frames['popupform-iframe' + instance];
303304 var innerJ = innerwdw.jQuery;
304305
305 -// content.bind("DOMSubtreeModified", function( evt ){
306 -// adjustFrameSize( true );
307 -// });
308 -
309306 if (form.length > 0) {
310307
311308 var submitok = false;
@@ -619,8 +616,8 @@
620617 }, {
621618 duration: 500,
622619 complete: function() {
623 - iframe[0].style.overflow="visible";
624 - html[0].style.overflow="visible";
 620+ iframe[0].style.overflow="auto";
 621+ html[0].style.overflow="auto";
625622
626623 if ( jQuery.browser.mozilla ) {
627624 content
@@ -753,6 +750,6 @@
754751 // export public funcitons
755752 this.handlePopupFormInput = handlePopupFormInput;
756753 this.handlePopupFormLink = handlePopupFormLink;
757 - this.adjustFrameSize =adjustFrameSize;
 754+ this.adjustFrameSize = adjustFrameSize;
758755
759756 }