r83614 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83613‎ | r83614 | r83615 >
Date:22:56, 9 March 2011
Author:yaron
Status:deferred
Tags:
Comment:
Attempted fix so that the presence of "no autocomplete" doesn't lead to an infinite loop
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormInputs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormInputs.php
@@ -187,7 +187,8 @@
188188 global $sfgTabIndex, $sfgFieldNum;
189189
190190 // For backward compatibility with pre-SF-2.1 forms
191 - if ( array_key_exists( 'autocomplete field type', $other_args ) ) {
 191+ if ( array_key_exists( 'autocomplete field type', $other_args ) &&
 192+ ! array_key_exists( 'no autocomplete', $other_args ) ) {
192193 return SFTextWithAutocompleteInput::getHTML( $cur_value, $input_name, $is_mandatory, $is_disabled, $other_args );
193194 }
194195