r83551 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83550‎ | r83551 | r83552 >
Date:23:15, 8 March 2011
Author:reedy
Status:ok
Tags:
Comment:
MFT r83550
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
@@ -334,8 +334,13 @@
335335 // Get committer wiki user name, or repo name at least
336336 $commitAuthor = $this->getWikiUser();
337337
338 - $commitAuthorId = $commitAuthor->getId();
339 - $committer = $commitAuthor ? $commitAuthor->getName() : htmlspecialchars( $this->mAuthor );
 338+ if ( $commitAuthor ) {
 339+ $committer = $commitAuthor->getName();
 340+ $commitAuthorId = $commitAuthor->getId();
 341+ } else {
 342+ $committer = htmlspecialchars( $this->mAuthor );
 343+ $commitAuthorId = 0;
 344+ }
340345
341346 // Get the authors of these revisions
342347 $res = $dbw->select( 'code_rev',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83550Fix stupid fatal where wiki user isn't attached/doesn't existreedy23:07, 8 March 2011

Status & tagging log