r83526 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83525‎ | r83526 | r83527 >
Date:15:54, 8 March 2011
Author:vyznev
Status:ok
Tags:
Comment:
revert r83521; this needs to be fixed better, but fixing the crash is first priority
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -290,8 +290,7 @@
291291 if ( $target->getPrefixedText() == '' ) {
292292 # A link like [[#Foo]]. This used to mean an empty title
293293 # attribute, but that's silly. Just don't output a title.
294 - } elseif ( $known &&
295 - Language::lc($linkText) !== Language::lc($target->getPrefixedText() ) ) {
 294+ } elseif ( $known && strtolower($linkText) !== strtolower($target->getPrefixedText() ) ) {
296295 $defaults['title'] = $target->getPrefixedText();
297296 } elseif ( !$known ) {
298297 $defaults['title'] = wfMsg( 'red-link-title', $target->getPrefixedText() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83521followup r76127 — use language-aware comparison between link text and possi...mah14:38, 8 March 2011

Status & tagging log