r83520 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83519‎ | r83520 | r83521 >
Date:13:27, 8 March 2011
Author:platonides
Status:deferred
Tags:
Comment:
The +1 added in r83519 wasn't needed.
Modified paths:
  • /trunk/php/wmerrors/wmerrors.c (modified) (history)

Diff [purge]

Index: trunk/php/wmerrors/wmerrors.c
——@@ -341,7 +341,7 @@
342342 /* Write it */
343343 convert_to_string(trace);
344344 WMERRORS_G(recursion_guard) = 2;
345 - Z_STRVAL_P(trace) = erealloc(Z_STRVAL_P(trace), Z_STRLEN_P(trace)+sizeof(PHP_EOL)+1);
 345+ Z_STRVAL_P(trace) = erealloc( Z_STRVAL_P(trace), Z_STRLEN_P(trace)+sizeof(PHP_EOL) );
346346 memcpy(Z_STRVAL_P(trace) + Z_STRLEN_P(trace), PHP_EOL, sizeof(PHP_EOL));
347347 php_stream_write(logfile_stream, Z_STRVAL_P(trace), Z_STRLEN_P(trace) TSRMLS_CC);
348348 WMERRORS_G(recursion_guard) = 1;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83519Concatenate the EOL to the string, so that it is sent in the same block in ph...platonides13:25, 8 March 2011

Status & tagging log