r83515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83514‎ | r83515 | r83516 >
Date:07:27, 8 March 2011
Author:hashar
Status:ok
Tags:
Comment:
switch 'column' for 'colon'

I always thought the colon and semicolon punctuation marks were named after
their architectural equivalent: column. At least, to me, it made more sens
than using a term relating to thedigestive system.

Per Nikerabbit r83296
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/HttpTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/HttpTest.php
@@ -555,7 +555,7 @@
556556 array( false, 'telnet://host', 'Reject telnet scheme' ),
557557
558558 # :\/\/ - double slashes
559 - array( false, 'http//example.org', 'Reject missing column in protocol' ),
 559+ array( false, 'http//example.org', 'Reject missing colon in protocol' ),
560560 array( false, 'http:/example.org', 'Reject missing slash in protocol' ),
561561 array( false, 'http:example.org', 'Must have two slashes' ),
562562 # Following fail since hostname can be made of anything
@@ -568,7 +568,7 @@
569569
570570 # (\S+) - host part is made of anything not whitespaces
571571 array( false, 'http://!"èèè¿¿¿~~\'', 'hostname is made of any non whitespace' ),
572 - array( false, 'http://exam:ple.org/', 'hostname can not use columns!' ),
 572+ array( false, 'http://exam:ple.org/', 'hostname can not use colons!' ),
573573
574574 # (:[0-9]+)? - port number
575575 array( true, 'http://example.org:80/' ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83296Tests for bug 27854 - Http::isValidURI is to lax...hashar16:15, 5 March 2011

Status & tagging log