r83492 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83491‎ | r83492 | r83493 >
Date:00:20, 8 March 2011
Author:platonides
Status:ok
Tags:
Comment:
Comment the var_dump() and add a comment.
Follow up r83208.
Modified paths:
  • /trunk/phase3/includes/objectcache/EhcacheBagOStuff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/objectcache/EhcacheBagOStuff.php
@@ -1,5 +1,9 @@
22 <?php
33
 4+/**
 5+ * Client for the Ehcache RESTful web service - http://ehcache.org/documentation/cache_server.html
 6+ * TODO: Simplify configuration and add to the installer.
 7+ */
48 class EhcacheBagOStuff extends BagOStuff {
59 var $servers, $cacheName, $connectTimeout, $timeout, $curlOptions,
610 $requestData, $requestDataPos;
@@ -205,7 +209,7 @@
206210
207211 protected function doRequest( $curl, $url, $curlOptions = array() ) {
208212 if ( array_diff_key( $curlOptions, $this->curlOptions ) ) {
209 - var_dump( array_diff_key( $curlOptions, $this->curlOptions ) );
 213+ // var_dump( array_diff_key( $curlOptions, $this->curlOptions ) );
210214 throw new MWException( __METHOD__.": to prevent options set in one doRequest() " .
211215 "call from affecting subsequent doRequest() calls, only options listed " .
212216 "in \$this->curlOptions may be specified in the \$curlOptions parameter." );

Sign-offs

UserFlagDate
Hasharinspected09:29, 8 March 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r84727Merged in the ObjectCache refactor and the Ehcache client. MFT r83135, r83136...tstarling03:28, 25 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83208* Added an Ehcache client....tstarling06:01, 4 March 2011

Status & tagging log