r83419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83418‎ | r83419 | r83420 >
Date:23:22, 6 March 2011
Author:platonides
Status:deferred
Tags:
Comment:
$wgCaches removed in r83140. Installer.php no longer uses $errs and $mainListOpened.
Modified paths:
  • /trunk/tools/code-utils/check-vars.php (modified) (history)

Diff [purge]

Index: trunk/tools/code-utils/check-vars.php
@@ -168,7 +168,6 @@
169169 }
170170
171171 protected static $mGlobalsPerFile = array( # Variables which are OK, but only on a few files
172 - '$wgCaches' => array( 'ObjectCache.php', 'phpunit', 'ForkController.php' ),
173172 '$wgDatabase' => array( 'updaters.inc', 'Installer.php', 'install-utils.inc', 'update.php', 'SqliteInstaller.php' ), # For update scripts
174173 '$wgHtmlEntities' => array( 'Sanitizer.php' ),
175174 '$wgHtmlEntityAliases' => array( 'Sanitizer.php' ),
@@ -178,8 +177,6 @@
179178 '$wgDatabase' => array( 'DatabaseUpdater.php' ),
180179 '$wgExtPGNewFields' => array( 'DatabaseUpdater.php', 'PostgresUpdater.php' ),
181180 '$wgExtPGAlteredFields' => array( 'DatabaseUpdater.php', 'PostgresUpdater.php' ),
182 - '$errs' => array( 'Installer.php' ),
183 - '$mainListOpened' => array( 'Installer.php' ),
184181 '$optionsWithArgs' => array( 'commandLine.inc' ),
185182 '$args' => array( 'commandLine.inc' ),
186183 '$options' => array( 'commandLine.inc', 'upgrade1_5.php' ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83140* Rewrote ObjectCache.php to conform to the modern coding style, and to be le...tstarling09:37, 3 March 2011

Status & tagging log