r83398 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83397‎ | r83398 | r83399 >
Date:19:52, 6 March 2011
Author:demon
Status:deferred
Tags:
Comment:
(bug 26690) Value of the 'Name of wiki' field is not retain after two subsequent click on 'Continue' button. This has been a complaint since the beginning, that the installer "forgets" $wgSitename.

The original intention, as I saw it, was to encourage people from choosing 'MediaWiki' as the name of their wiki. Just hardcode it, I don't think we're changing the name anytime soon.
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerPage.php
——@@ -552,7 +552,11 @@
553553
554554 $this->startForm();
555555
556 - if ( $this->getVar( 'wgSitename' ) == $GLOBALS['wgSitename'] ) {
 556+ // Encourage people to not name their site 'MediaWiki' by blanking the
 557+ // field. I think that was the intent with the original $GLOBALS['wgSitename']
 558+ // but these two always were the same so had the effect of making the
 559+ // installer forget $wgSitename when navigating back to this page.
 560+ if ( $this->getVar( 'wgSitename' ) == 'MediaWiki' ) {
557561 $this->setVar( 'wgSitename', '' );
558562 }
559563

Status & tagging log