r83380 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83379‎ | r83380 | r83381 >
Date:11:29, 6 March 2011
Author:tbleher
Status:deferred
Tags:
Comment:
Add IPv6 localhost address; more debugging information in case of errors

The debug information is needed because users do not necessarily see the
information (browsers will normally just display a broken image icon in case of
errors, but not the error information itself).
Modified paths:
  • /trunk/extensions/WebStore/WebStore.php (modified) (history)
  • /trunk/extensions/WebStore/WebStoreCommon.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WebStore/WebStore.php
@@ -5,12 +5,12 @@
66 * Set this in LocalSettings.php to an array of IP ranges allowed to access
77 * the store. Empty by default for maximum security.
88 */
9 - 'accessRanges' => array( '127.0.0.1' ),
 9+ 'accessRanges' => array( '127.0.0.1', '::1' ),
1010
1111 /**
1212 * Access ranges for inplace-scaler.php
1313 */
14 - 'scalerAccessRanges' => array( '127.0.0.1' ),
 14+ 'scalerAccessRanges' => array( '127.0.0.1', '::1' ),
1515
1616 /**
1717 * Main public directory. If false, uses $wgUploadDirectory
Index: trunk/extensions/WebStore/WebStoreCommon.php
@@ -86,6 +86,7 @@
8787 global $wgLogo;
8888 $msgText = htmlspecialchars( wfMsgReal( $msgName, $msgParams ) );
8989 $encMsgName = htmlspecialchars( $msgName );
 90+ wfDebug( "WebStore failed with '$encMsgName: $msgText; additional info: $extra'\n" );
9091 $info = self::$httpErrors[$code];
9192 $logo = htmlspecialchars( $wgLogo );
9293 header( "HTTP/1.1 $code $info" );

Status & tagging log