r83361 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83360‎ | r83361 | r83362 >
Date:02:48, 6 March 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
rem dead code
Modified paths:
  • /branches/Maps0.8/includes/services/GoogleMaps3/Maps_GoogleMaps3.php (modified) (history)
  • /branches/Maps0.8/includes/services/GoogleMaps3/ext.maps.googlemaps3.js (modified) (history)

Diff [purge]

Index: branches/Maps0.8/includes/services/GoogleMaps3/Maps_GoogleMaps3.php
@@ -129,28 +129,6 @@
130130 }
131131
132132 /**
133 - * @see MapsMappingService::createMarkersJs
134 - *
135 - * @since 0.6.5
136 - */
137 - public function createMarkersJs( array $markers ) {
138 - $markerItems = array();
139 -
140 - foreach ( $markers as $marker ) {
141 - $markerItems[] = Xml::encodeJsVar( (object)array(
142 - 'lat' => $marker[0],
143 - 'lon' => $marker[1],
144 - 'title' => $marker[2],
145 - 'label' =>$marker[3],
146 - 'icon' => $marker[4]
147 - ) );
148 - }
149 -
150 - // Create a string containing the marker JS.
151 - return '[' . implode( ',', $markerItems ) . ']';
152 - }
153 -
154 - /**
155133 * Returns the names of all supported map types.
156134 *
157135 * @return array
@@ -171,8 +149,7 @@
172150 $languageCode = self::getMappedLanguageCode( $wgLang->getCode() );
173151
174152 return array(
175 - Html::linkedScript( "http://maps.google.com/maps/api/js?sensor=false&language=$languageCode" ),
176 - //Html::linkedScript( "$egMapsScriptPath/includes/services/GoogleMaps3/GoogleMap3Functions.js?$egMapsStyleVersion" ),
 153+ Html::linkedScript( "http://maps.google.com/maps/api/js?sensor=false&language=$languageCode" )
177154 );
178155 }
179156
@@ -211,4 +188,4 @@
212189 );
213190 }
214191
215 -}
\ No newline at end of file
 192+}
Index: branches/Maps0.8/includes/services/GoogleMaps3/ext.maps.googlemaps3.js
@@ -5,25 +5,6 @@
66 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
77 */
88
9 -/*
10 -jQuery.getScript(
11 - 'http://maps.google.com/maps/api/js?sensor=false',
12 - function () {
13 - if ( true ) {
14 - for ( i in window.maps.googlemaps3 ) {
15 - jQuery( '#' + i ).googlemaps( window.maps.googlemaps3[i] );
16 - }
17 - }
18 - else {
19 - alert( mediaWiki.msg( 'maps-googlemaps3-incompatbrowser' ) );
20 -
21 - for ( i in window.maps.googlemaps3 ) {
22 - jQuery( '#' + i ).text( mediaWiki.msg( 'maps-load-failed' ) );
23 - }
24 - }
25 - }
26 -);*/
27 -
289 jQuery(document).ready(function() {
2910 if ( true ) {
3011 for ( i in window.maps.googlemaps3 ) {
@@ -37,4 +18,4 @@
3819 jQuery( '#' + i ).text( mediaWiki.msg( 'maps-load-failed' ) );
3920 }
4021 }
41 -});
\ No newline at end of file
 22+});

Status & tagging log