r83353 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83352‎ | r83353 | r83354 >
Date:01:52, 6 March 2011
Author:krinkle
Status:ok
Tags:
Comment:
Fixing (bug 27883) Spinner keeps spinning if codediff fails
Modified paths:
  • /trunk/extensions/CodeReview/modules/ext.codereview.loaddiff.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/modules/ext.codereview.loaddiff.js
@@ -21,9 +21,11 @@
2222 }
2323 });
2424 } catch ( e ) {
 25+ removeSpinner( 'codereview-diff' );
2526 if ( window.location.hostname == 'localhost' ) {
2627 alert( 'Your browser blocks XMLHttpRequest to "localhost", try using a real hostname for development/testing.' );
2728 }
 29+ CodeReview.setDiff( 'Diff load failed!' );
2830 throw e;
2931 }
3032 },

Status & tagging log