r83324 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83323‎ | r83324 | r83325 >
Date:20:09, 5 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r83294, fixup another usage of a path
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -41,6 +41,13 @@
4242 return $path;
4343 }
4444
 45+ /**
 46+ * @return string
 47+ */
 48+ public function getPathsAsString() {
 49+ return implode( '|', $this->mPath );
 50+ }
 51+
4552 function execute() {
4653 global $wgOut, $wgUser, $wgRequest, $wgLang;
4754 if ( !$this->mRepo ) {
@@ -184,7 +191,7 @@
185192 $ret = Xml::openElement( 'form', array( 'action' => $wgScript, 'method' => 'get' ) ) .
186193 "<fieldset><legend>" . wfMsgHtml( 'code-pathsearch-legend' ) . "</legend>" .
187194 '<table width="100%"><tr><td>' .
188 - Xml::inputlabel( wfMsg( "code-pathsearch-path" ), 'path', 'path', 55, implode( '|', $this->mPath ) ) .
 195+ Xml::inputlabel( wfMsg( "code-pathsearch-path" ), 'path', 'path', 55, $this->getPathsAsString() ) .
189196 '&#160;' . Xml::submitButton( wfMsg( 'allpagessubmit' ) ) .
190197 '</td>';
191198
@@ -327,7 +334,7 @@
328335
329336 function formatRevValue( $name, $value, $row ) {
330337 global $wgLang;
331 - $pathQuery = count( $this->mView->mPath ) ? array( 'path' => $this->mView->mPath ) : array();
 338+ $pathQuery = count( $this->mView->mPath ) ? array( 'path' => $this->mView->getPathsAsString() ) : array();
332339
333340 switch( $name ) {
334341 case 'selectforchange':

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83294* (bug 19007) Allow (delimited) list of paths in Special:Code filterreedy16:05, 5 March 2011

Status & tagging log