r83251 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83250‎ | r83251 | r83252 >
Date:22:28, 4 March 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
move return with $out inside the if block
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -559,7 +559,7 @@
560560 self::reportTranslationServiceFailure( $serviceName );
561561 break; // Too slow, back off
562562 } elseif ( $response->responseStatus !== 200 ) {
563 - error_log( __METHOD__ . " with ($serviceName ($candidate|$code)): " . $response->responseDetails );
 563+ error_log( __METHOD__ . " (HTTP {$response->responseStatus}) with ($serviceName ($candidate|$code)): " . $response->responseDetails );
564564 } else {
565565 $sug = Sanitizer::decodeCharReferences( $response->responseData->translatedText );
566566 $sug = trim( $sug );
@@ -778,9 +778,8 @@
779779 }
780780 }
781781 }
782 -
 782+ return "<hr />$out";
783783 }
784 - return "<hr />$out";
785784 }
786785 }
787786

Status & tagging log