r83244 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83243‎ | r83244 | r83245 >
Date:21:23, 4 March 2011
Author:awjrichards
Status:deferred
Tags:
Comment:
Fixing misspelling of 'orderid' field - for some obnoxious reason the param is named 'order_id' internally but 'orderid' in the form field. This should be fixed in the future - for all data fields - for consistency sake. and the sake of my sanity.
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/includes/payflowUser.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/includes/payflowUser.inc
——@@ -39,7 +39,7 @@
4040 global $wgRequest;
4141
4242 // is an order_id already set?
43 - $order_id = $wgRequest->getText( 'order_id', 0 );
 43+ $order_id = $wgRequest->getText( 'orderid', 0 );
4444
4545 // if the form was not just posted OR there's no order_id set, generate one.
4646 if ( !$wgRequest->wasPosted() || !$order_id ) {

Status & tagging log