r83163 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83162‎ | r83163 | r83164 >
Date:19:37, 3 March 2011
Author:kaldari
Status:deferred
Tags:
Comment:
fix for Bug 26190
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -2210,14 +2210,8 @@
22112211 var thanksDiv = $j( '<div class="mwe-upwiz-thanks ui-helper-clearfix" />' );
22122212 _this.thanksDiv = thanksDiv;
22132213
2214 - var thumbnailDiv = $j( '<div class="mwe-upwiz-thumbnail mwe-upwiz-thumbnail-side"></div>' );
 2214+ var thumbnailDiv = $j( '<div class="mwe-upwiz-thumbnail mwe-upwiz-thumbnail-side" id="thanks-thumbnail"></div>' );
22152215 upload.setThumbnail( thumbnailDiv );
2216 - thumbnailDiv.append( $j('<p/>').append(
2217 - $j( '<a />' )
2218 - .attr( { target: '_new',
2219 - href: upload.imageinfo.descriptionurl } )
2220 - .text( upload.title )
2221 - ) );
22222216
22232217 thanksDiv.append( thumbnailDiv );
22242218
@@ -2248,6 +2242,8 @@
22492243 );
22502244
22512245 $j( '#mwe-upwiz-thanks' ).append( thanksDiv );
 2246+ // Switch the thumbnail link so that it points to the image description page
 2247+ $j( '#thanks-thumbnail a' ).attr( 'href', upload.imageinfo.descriptionurl );
22522248 } );
22532249 },
22542250

Status & tagging log