r83018 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83017‎ | r83018 | r83019 >
Date:13:58, 1 March 2011
Author:freakolowsky
Status:ok
Tags:
Comment:
* forgot about those ...
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
@@ -243,11 +243,13 @@
244244 }
245245
246246 $session_mode = $this->mFlags & DBO_SYSDBA ? OCI_SYSDBA : OCI_DEFAULT;
 247+ wfSuppressWarnings();
247248 if ( $this->mFlags & DBO_DEFAULT ) {
248 - $this->mConn = @oci_new_connect( $this->mUser, $this->mPassword, $this->mServer, $this->defaultCharset, $session_mode );
 249+ $this->mConn = oci_new_connect( $this->mUser, $this->mPassword, $this->mServer, $this->defaultCharset, $session_mode );
249250 } else {
250 - $this->mConn = @oci_connect( $this->mUser, $this->mPassword, $this->mServer, $this->defaultCharset, $session_mode );
 251+ $this->mConn = oci_connect( $this->mUser, $this->mPassword, $this->mServer, $this->defaultCharset, $session_mode );
251252 }
 253+ wfRestoreWarnings();
252254
253255 if ( $this->mUser != $this->mDBname ) {
254256 //change current schema in session

Status & tagging log